-
Notifications
You must be signed in to change notification settings - Fork 137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
reverted random integer seeding to numpy #253
Conversation
I still need a test for this. I'll have to work on it soon. |
@@ -245,7 +245,7 @@ def _readMoreXMLbase(self,xmlNode): | |||
' '.join([i if i in self.toBeSampled.keys() else "" for i in self.constants.keys()]) ) | |||
|
|||
if self.initSeed == None: | |||
self.initSeed = randomUtils.randomIntegers(0,2**31,self) | |||
self.initSeed = np.random.randint(0,2**31) #NOTE: DO NOT change this random int to generate from crow! Need a more random seeed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Numpy is not imported into this file.
Job Mingw Test on b5ee90c : canceled by @joshua-cogliati-inl other tests failed. |
Job Test qsubs on b5ee90c : canceled by @joshua-cogliati-inl other tests failed. |
What is the situation with this? |
I haven't had the opportunity to come back and finish this. There's still a handful of implementations that need to be converted over, according to my notes. |
All jobs on 654bd67 : canceled by @PaulTalbot-INL just mergefix, not ready for new testing |
At this point this PR should be restarted due to the number of changes in the code since it was started. The issue still stands; we need a unified and consistent usage of random numbers in RAVEN runs, and it should be clear to the user whether they are in a seeded or different-each-time environment. |
Pull Request Description
What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)
Closes #252.
What are the significant changes in functionality due to this change request?
Leaves initial seed to numpy if it is not specified by the user.
For Change Control Board: Change Request Review
The following review must be completed by an authorized member of the Change Control Board.
<internalParallel>
to True.