Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reverted random integer seeding to numpy #253

Closed

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Jul 18, 2017


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Closes #252.

What are the significant changes in functionality due to this change request?

Leaves initial seed to numpy if it is not specified by the user.


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

@PaulTalbot-INL
Copy link
Collaborator Author

I still need a test for this. I'll have to work on it soon.

@@ -245,7 +245,7 @@ def _readMoreXMLbase(self,xmlNode):
' '.join([i if i in self.toBeSampled.keys() else "" for i in self.constants.keys()]) )

if self.initSeed == None:
self.initSeed = randomUtils.randomIntegers(0,2**31,self)
self.initSeed = np.random.randint(0,2**31) #NOTE: DO NOT change this random int to generate from crow! Need a more random seeed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Numpy is not imported into this file.

@moosebuild
Copy link

Job Mingw Test on b5ee90c : canceled by @joshua-cogliati-inl

other tests failed.

@moosebuild
Copy link

Job Test qsubs on b5ee90c : canceled by @joshua-cogliati-inl

other tests failed.

@alfoa
Copy link
Collaborator

alfoa commented Sep 12, 2017

What is the situation with this?

@PaulTalbot-INL
Copy link
Collaborator Author

I haven't had the opportunity to come back and finish this. There's still a handful of implementations that need to be converted over, according to my notes.

@moosebuild
Copy link

All jobs on 654bd67 : canceled by @PaulTalbot-INL

just mergefix, not ready for new testing

@PaulTalbot-INL
Copy link
Collaborator Author

At this point this PR should be restarted due to the number of changes in the code since it was started. The issue still stands; we need a unified and consistent usage of random numbers in RAVEN runs, and it should be clear to the user whether they are in a seeded or different-each-time environment.

@PaulTalbot-INL PaulTalbot-INL deleted the random_initial_seed branch June 7, 2018 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Non-specified initial seeds are still consistently the same
4 participants