Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: DataObject Rework with xarray: PointSet replacement #418

Closed
wants to merge 70 commits into from

Conversation

PaulTalbot-INL
Copy link
Collaborator

@PaulTalbot-INL PaulTalbot-INL commented Nov 1, 2017


Pull Request Description

What issue does this change request address? (Use "#" before the issue to link it, i.e., #42.)

Progress towards #182.

What are the significant changes in functionality due to this change request?

Adds DataSet, a data object that intends to replace both PointSet and HistorySet with more efficient sampling, storage, access, and IO.

This PR creates DataSets, updates the libraries needed to use it, and under-the-hood replaces PointSets with DataSets by redirecting the PointSet factory.

DataSets have an idealized API, but for now also include the legacy API for backward compatability.

Also implements the "cNDarray", an ND expansion of the cached 1d array.

WORK IN PROGRESS


For Change Control Board: Change Request Review

The following review must be completed by an authorized member of the Change Control Board.

  • 1. Review all computer code.
  • 2. If any changes occur to the input syntax, there must be an accompanying change to the user manual and xsd schema. If the input syntax change deprecates existing input files, a conversion script needs to be added (see Conversion Scripts).
  • 3. Make sure the Python code and commenting standards are respected (camelBack, etc.) - See on the wiki for details.
  • 4. Automated Tests should pass, including run_tests, pylint, manual building and xsd tests. If there are changes to Simulation.py or JobHandler.py the qsub tests must pass.
  • 5. If significant functionality is added, there must be tests added to check this. Tests should cover all possible options. Multiple short tests are preferred over one large test. If new development on the internal JobHandler parallel system is performed, a cluster test must be added setting, in XML block, the node <internalParallel> to True.
  • 6. If the change modifies or adds a requirement or a requirement based test case, the Change Control Board's Chair or designee also needs to approve the change. The requirements and the requirements test shall be in sync.
  • 7. The merge request must reference an issue. If the issue is closed, the issue close checklist shall be done.
  • 8. If an analytic test is changed/added is the the analytic documentation updated/added?

PaulTalbot-INL and others added 30 commits April 6, 2017 11:16
This can be used if the user does not have access to change /opt
@PaulTalbot-INL PaulTalbot-INL changed the title WIP: DataObject Rework with xarray WIP: DataObject Rework with xarray: PointSet replacement Nov 1, 2017
@alfoa
Copy link
Collaborator

alfoa commented Dec 4, 2017

I think this one can be removed.

@PaulTalbot-INL
Copy link
Collaborator Author

Yes, true. Closing, as a more comprehensive change is coming by way of the development branch dataobject-rework.

@PaulTalbot-INL PaulTalbot-INL deleted the cached_xarray branch June 7, 2018 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants