Loading dataset fully from dict #441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mandd
reviewed
Nov 28, 2017
framework/DataObjects/XDataSet.py
Outdated
| @@ -216,16 +216,15 @@ def extendExistingEntry(self,rlz): | |||
| # modify outputs to be pivot-dependent | |||
| toRemove = [] | |||
| # set up index vars for removal | |||
| allDims = self.getDimensions() | |||
| for var in rlz.keys(): | |||
| for var in self.indexes: | |||
There was a problem hiding this comment.
if self.indexes and allDims are lists, can we combine this "for" loop and "if" condition?
There was a problem hiding this comment.
Yes, I think so. Like... toRemove = (var for var in self.indexes if var in allDims) ?
| # pass # TODO need to make sure entries are all single entries! | ||
| data[:,i] = values | ||
| # set up collector as cached nd array of values | ||
| self._collector = cached_ndarray.cNDarray(values=data,dtype=object) |
There was a problem hiding this comment.
why not a numpy standard array?
There was a problem hiding this comment.
That's a good question. Given that we call asDataset() right afterwords, we can probably get away without using the cached array.
mandd
approved these changes
Nov 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Allows loading a DataSet directly from a dictionary using
data.load(dict, style='dict',dims={})syntax.