Upgrade to Molecule v2 #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sorobon
approved these changes
Jan 7, 2019
dortegau
reviewed
Jan 7, 2019
|
Looks like tests are failing :( |
jmonterrubio
approved these changes
Jan 8, 2019
jnogol
reviewed
Jan 8, 2019
| @@ -0,0 +1,14 @@ | |||
| [[source]] | |||
There was a problem hiding this comment.
The Pipfile and Pipfile.lock should be ignored :)
There was a problem hiding this comment.
Should be?
Should Pipfile.lock be committed to version control?
I had added all this files to the .gitignore file, but I don't know if should be ignored or not using pipenv to test Ansible Roles 🙁
There was a problem hiding this comment.
Well, let's leave them for the moment and see if anything explodes 😆
dortegau
approved these changes
Jan 9, 2019
jnogol
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
Upgrade to Molecule v2
Benefits
New Molecule version :) Maybe Scenarios is the most remarkable new feature.
Possible Drawbacks
Vagrant Molecule driver is not supported any more.
Applicable Issues
#11