Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#5 Allowing to provide both log file path and log level as arguments #11

Merged
merged 6 commits into from
Aug 28, 2017

Conversation

dortegau
Copy link
Member

No description provided.

bin/prom2teams Outdated
@@ -14,8 +14,10 @@ if __name__ == "__main__":
'and sends it to Microsoft Teams using configured connectors ')

parser.add_argument('-c', '--configpath', help='config INI file path', required=True)
parser.add_argument('-l', '--logfilepath', help='log file path', required=True)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These two must be required?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, after this PR must be.

What should do if these arguments aren't provided? Should redirect messages to stdout/stderr? Should disable logging? :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed 👍

dortegau and others added 3 commits August 27, 2017 22:36
#10 Capturing Keyboard Interrupt and logging server stop event
- Redirecting http server messages to defined logger
- Defining 'INFO' as default log level
@dortegau dortegau merged commit 0f0fdcf into bugs/8 Aug 28, 2017
@dortegau dortegau deleted the bugs/5 branch August 29, 2017 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants