Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow overriding the config file location in Docker by setting the APP_CONFIG_FILE environment variable #128

Merged
merged 4 commits into from
Aug 9, 2019
Merged

Allow overriding the config file location in Docker by setting the APP_CONFIG_FILE environment variable #128

merged 4 commits into from
Aug 9, 2019

Conversation

nvx
Copy link
Contributor

@nvx nvx commented Aug 7, 2019

This change sets the APP_CONFIG_FILE environment variable in the Dockerfile to set the default location of the config file rather than hard-coding it in the entrypoint script.

Benefits

This allows for specifying a custom path for the config file by setting an environment variable. This can be useful to work around issues like this hashicorp/nomad#4797 when using Nomad or consul-template to generate config files where a bind mount needs to be done on the folder rather than the file directly.

This also makes the behaviour of the Docker container more consistent with the behaviour when running outside a Docker container.

Possible Drawbacks

None, existing behaviour is retained unless the APP_CONFIG_FILE environment variable is overridden from the default value.

Applicable Issues

N/A

@dortegau
Copy link
Member

dortegau commented Aug 7, 2019

Please, could you add your change to the CHANGELOG.md file as is described here: https://github.com/idealista/prom2teams/blob/master/.github/CONTRIBUTING.md#changelog?

Thanks in advance!

@nvx
Copy link
Contributor Author

nvx commented Aug 8, 2019

Please, could you add your change to the CHANGELOG.md file as is described here: https://github.com/idealista/prom2teams/blob/master/.github/CONTRIBUTING.md#changelog?

Thanks in advance!

Done!

@jnogol jnogol changed the base branch from master to develop August 8, 2019 06:04
Dockerfile Outdated Show resolved Hide resolved
@jnogol jnogol merged commit 5f8d70f into idealista:develop Aug 9, 2019
@jnogol jnogol mentioned this pull request Aug 14, 2019
@nvx nvx deleted the feature/docker_config_file_location branch October 29, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants