Allow overriding the config file location in Docker by setting the APP_CONFIG_FILE environment variable #128
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change sets the APP_CONFIG_FILE environment variable in the Dockerfile to set the default location of the config file rather than hard-coding it in the entrypoint script.
Benefits
This allows for specifying a custom path for the config file by setting an environment variable. This can be useful to work around issues like this hashicorp/nomad#4797 when using Nomad or consul-template to generate config files where a bind mount needs to be done on the folder rather than the file directly.
This also makes the behaviour of the Docker container more consistent with the behaviour when running outside a Docker container.
Possible Drawbacks
None, existing behaviour is retained unless the APP_CONFIG_FILE environment variable is overridden from the default value.
Applicable Issues
N/A