Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Alert schema validation #149

Merged
merged 4 commits into from
Sep 16, 2019
Merged

Update Alert schema validation #149

merged 4 commits into from
Sep 16, 2019

Conversation

miguel-chacon
Copy link
Collaborator

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Alertmanager 0.19 adds new value in alert template. This PR updates schema validation.

Benefits

Possible Drawbacks

Applicable Issues

#148

@miguel-chacon miguel-chacon merged commit 08e22c8 into develop Sep 16, 2019
@miguel-chacon miguel-chacon deleted the prepare_alertmanager_update branch September 16, 2019 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sorobon sorobon sorobon approved these changes

@jperera jperera Awaiting requested review from jperera

@dortegau dortegau Awaiting requested review from dortegau

@frantsao frantsao Awaiting requested review from frantsao

@jmonterrubio jmonterrubio Awaiting requested review from jmonterrubio

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@miguel-chacon @sorobon