Add fingerprints #172
Merged
Add fingerprints #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fingerprints can be used by tools like chatbots to silence a specific alert.
jmonterrubio
requested review from
jmonterrubio,
dortegau,
frantsao,
jperera,
caldito,
sorobon,
Thasselhof and
blalop
jperera
approved these changes
Apr 1, 2020
frantsao
approved these changes
Apr 1, 2020
blalop
approved these changes
Apr 1, 2020
caldito
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
I exposed the "fingerprint" field for Prometheus alerts, so that they can be rendered in the Teams output.
Benefits
Some Alertmanager tools can search for alerts by their fingerprint. With this ID, those users can uniquely identify alerts, and perform actions on them (for example, silencing).
Possible Drawbacks
This change should be backwards compatible with existing templates. Users that do not use the fingerprint field explicitly should be unaffected. I did not add the fingerprint field to the default template.
Applicable Issues
None