#189 Fixed handling of additional json properties of alertmanager 0.21.0. #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good! |
dortegau
approved these changes
Jul 13, 2020
dortegau
requested review from
blalop,
jmonterrubio,
jnogol,
jperera,
caldito,
sorobon,
frantsao and
Thasselhof
blalop
approved these changes
Jul 13, 2020
frantsao
approved these changes
Jul 13, 2020
caldito
approved these changes
Jul 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
See Issue #189. Additional json properties in an alert request are not ignored, but raise an execption, breaking any setup with alertmangaer 0.21+.
I added a configuration to the schema to allow for and ignore additional json properties.
https://marshmallow.readthedocs.io/en/stable/quickstart.html#handling-unknown-fields
Benefits
Possible Drawbacks
Applicable Issues
#189