Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add timeouts to webhook requests.
Requirements
Description of the Change
I found the application in a state where it was logging messages like "uWSGI listen queue of socket full". There was a lot of connections to a uwsgi worker in close wait so I assume that over time network errors had accumulated connections to the point where the application would no longer serve requests from alertmanager.
Benefits
Possible Drawbacks
Might want the timeouts configurable, however I set them generous for the purpose of avoiding bad state.
Applicable Issues