#21 Verify optional/mandatory fields #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be merged into develop instead of master (changed) |
dortegau
requested changes
Sep 18, 2017
prom2teams/message/parser.py
Outdated
| @@ -6,19 +6,28 @@ | |||
|
|
|||
|
|
|||
| def parse(json_str): | |||
| logger.debug('received: %s', json_str) | |||
|
|
|||
| return_dict = {} | |||
There was a problem hiding this comment.
including type information (dict) in a variable name is considered an antipattern:
prom2teams/message/parser.py
Outdated
| 'alert_description': json_alerts_annotations_attr['description'], | ||
| 'alert_status': json_alerts_attr['status'] | ||
| } | ||
| mandatory_fields = ['alertname', 'status', 'instance', 'summary'] |
There was a problem hiding this comment.
Shouldn't be extracted to a new def? (check_mandatory_fields ¿?)
prom2teams/message/parser.py
Outdated
|
|
||
| for field in fields: | ||
| if field in json_alerts_attr: | ||
| return_dict['alert_'+field] = json_alerts_attr[field] |
There was a problem hiding this comment.
'alert_'+field should be extracted to a variable before the conditional
dortegau
approved these changes
Nov 2, 2017
jdvr
reviewed
Nov 3, 2017
|
Agree. Working on it. |
added 3 commits
November 3, 2017 11:45
…prom2teams into features/optional_json_fields
|
Done. Check the changes out @jdvr @dortegau @jmonterrubio |
jdvr
approved these changes
Nov 6, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
alertnametoalert_alertname(to make it easier to loop over it).