Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue 271 - Sending a message with double quotes in TeamsAlert fields breaks MS Teams communication #272

Merged
merged 2 commits into from
Aug 24, 2021

Conversation

earthquakesan
Copy link

Requirements

  • Filling out the template is required. Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion.
  • All new code requires tests to ensure against regressions
  • Remember to set idealista:develop as base branch;

Description of the Change

Please refer to #271 for the description of the problem. The code introduced in this pull request simply removes all the quotes from all the fields in TeamAlert object.

Benefits

Messages with the quotes in the alerts can be sent to MS Teams channel.

Possible Drawbacks

Quotes are removed, if they are required/expected in some of the alerts, this can be potential drawback.

Applicable Issues

#271

@earthquakesan
Copy link
Author

Have build a docker image and tested it in our k8s environment. Fix works. Docker image is here: earthquakesan/prom2teams:271 (can be built from this PR).

@earthquakesan
Copy link
Author

SonarCloud is failing because Set the SONAR_TOKEN env variable., token expired?

@vicsufer
Copy link
Collaborator

Hi @earthquakesan, thanks for the contribution, we'll review the functionality and the PR as soon as possible.

The SonarCloud error is a known error when the PR comes from a forked repository so do not worry 😄 .

@dortegau
Copy link
Member

Thanks for your contribution to prom2teams :)

Could you update the changelog? Thanks!

@earthquakesan
Copy link
Author

@dortegau did done! -)

Copy link
Member

@dortegau dortegau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM :)

@vicsufer vicsufer self-requested a review August 24, 2021 06:54
@dortegau dortegau merged commit e96397b into idealista:develop Aug 24, 2021
@earthquakesan
Copy link
Author

@dortegau @vicsufer good weekends to you! I am pondering about release cycle of this repo. We are using a custom build with this patch right now, but it is in the trunk already and it would be great to switch to a release version.

When is the next release planned? Can I help with it somehow?

@vicsufer
Copy link
Collaborator

Hi @earthquakesan since prom2teams has nota big volume of new contributions we tend to release new versions as new feautres/fixes arrive, this time we had a few open PRs so we were delaying the release for a bit.

At the moment we've started a release at #278 so you can expect your fix soon 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants