Bugfix/307 Fix replace_config to read prom2teams config #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santi-eidu
changed the title
|
then? what it will be reviewed ? |
abdennour
suggested changes
Dec 6, 2022
docker/rootfs/replace_config.py
Outdated
| with open('/opt/prom2teams/config.ini', 'w') as file: | ||
| file.write(filedata) | ||
| except (PermissionError, OSError) as error: | ||
| pass |
There was a problem hiding this comment.
Why are you bypassing error handling ? If there is actual error, why we ignore it
There was a problem hiding this comment.
Change to tmp config files in case of config file from docker volume.
docker/rootfs/replace_config.py
Outdated
| try: | ||
| with open('/opt/prom2teams/uwsgi.ini', 'w') as file: | ||
| file.write(uwsgi_filedata) | ||
| except (PermissionError, OSError) as error: |
There was a problem hiding this comment.
Change to tmp config files in case of config file from docker volume.
|
Kudos, SonarCloud Quality Gate passed!
|
santi-eidu
requested review from
blalop,
dortegau,
emepege,
frantsao,
jmonterrubio,
jperera,
marcelogalmor,
MarioNv91,
ommarmol,
smartinsempere,
sorobon,
ultraheroe and
xtianae7
frantsao
approved these changes
Dec 7, 2022
jperera
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirements
Description of the Change
After #307 in version 4.0.0 prom2teams config in docker volume returns an error. With tmp files you can control when to replace variables.
Benefits
Now you can add prom2teams config via volumen in docker.
Possible Drawbacks
N/A.
Applicable Issues
#307