-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename cycleway
to directionalCombo
#83
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tordans
force-pushed
the
introduce-directioncombo
branch
from
December 28, 2022 12:54
6beda27
to
0edcf2e
Compare
Rename `cycleway` to `directionalCombo` Following the update in iD (https://github.com/openstreetmap/iD/pull/9423/files#diff-b3604385ed7e095c6c6fd1973a4c3d376f21e56f26452299a358d033411a38f6R65-R67) this changes the name of the field to make it reusable. Fixes ideditor#79
tordans
force-pushed
the
introduce-directioncombo
branch
from
December 28, 2022 12:54
0edcf2e
to
9d5b70e
Compare
tordans
added a commit
to tordans/id-tagging-schema
that referenced
this pull request
Dec 28, 2022
See ideditor/schema-builder#83 for more about the rename.
7 tasks
* this will likely get released as v6.0, as it's a basically breaking change * the link to the readme is not needed IMO
like rivers, railways, etc.
I'll do this before I package this into a release. |
FYI: in 2714c23, I tweaked this one last time:
for example, this is how the
This is to make the implicit distinction between the common and directional subtags a bit more explicit (compared to relying on implicit order in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the update in iD (https://github.com/openstreetmap/iD/pull/9423/files#diff-b3604385ed7e095c6c6fd1973a4c3d376f21e56f26452299a358d033411a38f6R65-R67) this changes the name of the field to make it reusable.
AFAIK this is all that needs to happen in this repo, right?
Fixes #79