support refresh credential message #36
Conversation
protocol/credentials.go
Outdated
|
|
||
| // CredentialRefreshMessageBody is msg body for refresh message | ||
| type CredentialRefreshMessageBody struct { | ||
| ID string `json:"id"` |
There was a problem hiding this comment.
maybe it should be an array of ID's like an credential offer, and reason field might be applicable
There was a problem hiding this comment.
Good point. In case we have multi proof request and all claims are revoked we need to refresh the scope of creds.
There was a problem hiding this comment.
I think that the reason field is redundant. What should the user submit in it? We already know that the only case where the refresh service can receive this message is a reissue the credential.
There was a problem hiding this comment.
it is always useful to let leave a place for explanation.
protocol/credentials.go
Outdated
|
|
||
| // CredentialRefreshMessageBody is msg body for refresh message | ||
| type CredentialRefreshMessageBody struct { | ||
| Refresh []Refresh `json:"refresh"` |
There was a problem hiding this comment.
let's call it Credentials json:"credentials" as for Offer
iden3comm/protocol/credentials.go
Line 64 in 68b9ee9
protocol/credentials.go
Outdated
|
|
||
| // CredentialRefreshMessageBody is msg body for refresh message | ||
| type CredentialRefreshMessageBody struct { | ||
| Credential Refresh `json:"credentials"` |
There was a problem hiding this comment.
why do I need a credential field if it is only one credential
No description provided.