add AgentResolver #40
Conversation
…setter/getter to sender DID.
Refactor to new settings of user/issuer DIDs
| } | ||
|
|
||
| // AgentResolverConfig options for credential status verification | ||
| type AgentResolverConfig struct { |
There was a problem hiding this comment.
Can we use an options pattern? Or if it required field pass the PackageManager directly to NewAgentResolver constructor?
There was a problem hiding this comment.
no, it looks like you missed our discussions
resolvers/agent.go
Outdated
| return out, errors.WithStack(err) | ||
| } | ||
|
|
||
| idUUID, err := uuid.NewV4() |
There was a problem hiding this comment.
use github.com/google/uuid to generate uuid
resolvers/agent.go
Outdated
| return out, errors.WithStack(err) | ||
| } | ||
|
|
||
| resp, err := http.DefaultClient.Post(status.ID, "application/json", bytes.NewBuffer(iden3commMsg)) |
There was a problem hiding this comment.
pass the http client as option
resolvers/agent_test.go
Outdated
|
|
||
| agentResolver := NewAgentResolver(agentConfig) | ||
|
|
||
| httpmock.Activate() |
There was a problem hiding this comment.
Consider to use https://pkg.go.dev/net/http/httptest@go1.21.6
resolvers/agent.go
Outdated
| } | ||
| defer func() { | ||
| err2 := resp.Body.Close() | ||
| if err != nil { |
There was a problem hiding this comment.
if err2 != nil?
In this case if err == nil but err2 != nil you retrun an nil error. But expected an error.
There was a problem hiding this comment.
just return revocationStatus.RevocationStatus, err in the end of the function
resolvers/agent.go
Outdated
| } | ||
| }() | ||
|
|
||
| if resp.StatusCode != http.StatusOK { |
There was a problem hiding this comment.
Accept range of 2xx codes.
There was a problem hiding this comment.
200 is expected on all other clients.
|
In general, try to add context for all errors. A good example of why need to do it. idUUID, err := uuid.NewV4()
if err != nil {
return out, err
}
threadUUID, err := uuid.NewV4()
if err != nil {
return out, err
} |
resolvers/agent.go
Outdated
| // AgentResolverConfig options for credential status verification | ||
| type AgentResolverConfig struct { | ||
| PackageManager *iden3comm.PackageManager | ||
| customHTTPClient *http.Client |
There was a problem hiding this comment.
It is not possible to set customHTTPClient from the external package, since the field is private.
There was a problem hiding this comment.
made public
resolvers/agent.go
Outdated
| return out, errors.WithStack(err) | ||
| } | ||
|
|
||
| var httpClient *http.Client |
There was a problem hiding this comment.
refactor to
httpClient := http.DefaultClient
if r.config.customHTTPClient != nil {
httpClient = r.config.customHTTPClient
}
go.mod
Outdated
| github.com/gofrs/uuid/v5 v5.0.0 | ||
| github.com/google/uuid v1.6.0 |
There was a problem hiding this comment.
why do we have to uuid packages? I know Illiya aksed to use goohle uuid, but in this case let's remove gofrs completely.
No description provided.