This repository has been archived by the owner on Jun 14, 2022. It is now read-only.
Check if scrollbar exists before calling destroy function #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
componentWillUnmount
is called withoutcomponentDidMount
beforehand.For example:
componentWillUnmount
called withoutcomponentDidMount
FormidableLabs/freactal#40To be a bit more resilient is such cases I've added this workaround which checks if scrollbar was instantiated before calling it's
destroy
method.This doesn't solve the underlying bugs which cause this wrong lifecycle-method calling but it means there isn't an exception from scrollbar in such cases.