Issue 211: Dockerize #277
Merged
Issue 211: Dockerize #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements Dockerization for the application. Docker builds by freezing Poetry requirements, installing them with pip and setting the git remote for the !update command. Resolves #211
Removes redundant parsing of the current branch in the update command implementation.
Updates README with changes pertaining to Dockerization (Docker commands and new Repository configuration variable).
davidlougheed
requested changes
Mar 23, 2020
Addresses comments by @davidlougheed in #277
jidicula
requested changes
Mar 28, 2020
Addresses comments by @jidicula to use the collective gmail address in Git config.
Improves format and commenting of Dockerfile.
Require requirements to be frozen prior to installation to cache independent of pyproject.toml . This change allows flexibility for faster builds while bumping versions of project.
jidicula
approved these changes
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Dockerizes application and implements consequent changes:
updatecommand)updatecommand. (n.b. this is required as we must mount our host directory as a volume into the container and as such, the origin remote is set to whatever it is on the host. In order to avoid restricting developers to a single remote protocol (SSH or HTTPS), this allows the update command to pull from whatever branch is active on the host via HTTPS on this repository.)updatecommand to pull via HTTPS strictly.Motivation and Context
See #211 for details on this. This change allows portability across environments and takes us one step closer to fully automating our release process.
How Has This Been Tested?
Tested most commands locally - tested update repeatedly.
Screenshots (if appropriate):
Types of changes
Checklist: