Focus #10
Merged
Focus #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- new watchFocus(layerWrapper) to manipulate tabbing
- use watchFocus() to handle tabbing - unique id to layers and data attr with the id to the layer origin - renamed all layers to <zeejs-layer> - renamed layer origin nodes to <zeejs-origin>
- focus trap between layers above blocking backdrop - catch focus under inert and pass to first focusable element - inert attribute to layers under blocking layer
- set the correct layers+backdrop in DOM with order and focus inmind - new createRoot(): DOMLayer to contain all browser specific config
- handle re-focus in the updateLayers process - changed layer id to be an actual id instead of data-id - refactor react root to use createRoot from browser package -removed unnecessary setWrapper() in createRoot() - @zeejs/browser
- new option for async focus change in update layers - fix React implementation to async update focus during render
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds focus handling to layers.
[Tab]/[Shift+Tab]focus trapinside a layer with inert backgroundLeftovers: