Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the need for passing issuer's encryption public key at credent… #349

Merged
merged 5 commits into from
Nov 13, 2024

Conversation

Mohammed-Mamoun98
Copy link
Contributor

…ial creation

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
dashboard-for-dapps ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:32am
idos-data-dashboard ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:32am
idos-enclave ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:32am
idos-example-dapp ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 10:32am

Copy link

pkg-pr-new bot commented Nov 12, 2024

Open in Stackblitz

pnpm add https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/idos-sdk@349
pnpm add https://pkg.pr.new/idos-network/idos-sdk-js/@idos-network/issuer-sdk-js@349

commit: 00f80ff

Copy link
Collaborator

@ditoglez ditoglez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Mohammed-Mamoun98 tests are failing, other than that I would suggest @pkoch review this also.

@ditoglez ditoglez requested a review from pkoch November 13, 2024 09:53
@Mohammed-Mamoun98 Mohammed-Mamoun98 merged commit 315624d into main Nov 13, 2024
10 checks passed
@Mohammed-Mamoun98 Mohammed-Mamoun98 deleted the refactor/use-config-derived-key branch November 13, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants