-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python wrap #21
Open
typelogic
wants to merge
35
commits into
develop
Choose a base branch
from
python-wrap
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Python wrap #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Most of these changes are the addition of python files to wrap
libidpasslite.so
in python. There is an addition of one new functionidpass_lite_qrcodesvg
inidpass.h
header file. The outputting in SVG format directly inlibidpasslite.so
solves a lot of problems as the SVG is a universally portable, and visually scalable format. The python wrapping is also further malleable and currently it almost look the same in the Java JNI wrapping, having class definitionsReader
andCard
.In summary, the overall flow is:
where, the
johnsmith.json
is a json file containing identity details of a person, and the output is aqrcode.svg
SVG format.To see it in action, checkout the repo then:
qrcode1.svg
orqrcode2.svg
in a browserident1.json
or create a newident3.json
then generate its QR code.pin
code field. You will enter it in the Smartscanner app to decode more identity fields.IOCTL_SET_ACL
inIDPassNative.py
to control which fields are visible by default without need for pin authentication.privExtra
fields in the identity json always requires pin authentication in order for this field's value to be visiblepubExtra
fields in the identity is visible by default without need for pin authentication.