Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The documentation reads
However, writing
--config *config file*
would break with an obscure error message.This is because the filename would be passed as argument directly to the Dhall parser, rather than being read from the filesystem and be given to the dhall parser.
The reason it worked until now is because if you write
./filepath
, dhall knows to interpret it as a file to read from the filesystem and will perform the file reading for us. If you writefilepath
the dhall parser will fail assuming that it is an unbound variable. This PR fixes this behaviour by reading the file before passing its content to the parser.I also fixed some warnings due to conflicting fixity declarations.