Ensure that argument passed to idris-repl-insert-result is a string #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
not adding space between line number and expression in *xref* buffer
Why: Interpreting command `:load "Foo.idr"` produces output `(:ok nil)` from Idris. This leads to error `(wrong-type-argument char-or-string-p nil)` Fixes idris-hackers#620
Seems like the output formatting was updated from the time the `warning` handling in `idris-repl-event-hook-function` was introduced.
``` Error: custom-declare-variable *** docstring has wrong usage of unescaped single quotes (use \= or different quoting) ``` Introduced probably in Emacs 29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Interpreting command
:load "Foo.idr"produces output(:ok nil)from Idris.This leads to error
(wrong-type-argument char-or-string-p nil)Fixes #620
This PR also includes additional minor fixes for issues discovered in the process of fixing the #620