Emit warning for fixities with no export modifiers #3234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
andrevidela
force-pushed
the
fixity-export-warning
branch
from
3d09654 to
d6ac9a8
Compare
This is to help update all the existing code to program with explicit fixity export directives in preparation for the behavioral change where they will become private by default.
andrevidela
force-pushed
the
fixity-export-warning
branch
from
d6ac9a8 to
5773536
Compare
|
submitted a PR to frex to export fixities : frex-project/idris-frex#71 |
|
@stefan-hoeck is there an easy way to find out how many other libraries in the latest package collection will be affected by this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to help update all the existing code to program with explicit fixity export directives in preparation for the behavioral change where they will become private by default.
Description
This is part of #2998 stage 2
Should this change go in the CHANGELOG?
implementation, I have updated
CHANGELOG_NEXT.md(and potentially alsoCONTRIBUTORS.md).