refactor: do not use recursion but keep a stack #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
idubrov
approved these changes
Sep 11, 2023
src/lib.rs
Outdated
| @@ -423,76 +423,166 @@ fn test(doc: &Value, path: &str, expected: &Value) -> Result<(), PatchErrorKind> | |||
| /// # } | |||
| /// ``` | |||
| pub fn patch(doc: &mut Value, patch: &[PatchOperation]) -> Result<(), PatchError> { | |||
| apply_patches(doc, 0, patch) | |||
| let mut undo_stack = Vec::new(); | |||
There was a problem hiding this comment.
Really minor thing -- do you think you can reserve undo stack size? Vec::with_capacity(patch.len())?
idubrov
requested changes
Sep 11, 2023
|
Thanks! I've applied your suggestion. I'm not sure why the test was failing. The only change in the schema was that a description was added for |
|
Now it seems like codecov is failing.. I think the github action needs to be updated perhaps? |
|
Sorry about that. Yes, it turned out the test was broken on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this library we consistently ran into stack overflow issues. We traced this back to this crate which uses recursion to be able to revert operations in case of an error. This is problematic when applying large patches because it will quickly overflow the stack.
This PR does two things:
patch_unsafefunction which does not construct this undo stack and in turn leaves the document in an inconsistent state.In our case, we are applying large patches and we don't care at all if the document is in an inconsistent state in case of an error. We throw it away anyway. With this PR this significantly reduces memory usage and increases the performance of applying the patches.