Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropping treediff dependency. #38

Merged
merged 1 commit into from
May 6, 2024
Merged

Dropping treediff dependency. #38

merged 1 commit into from
May 6, 2024

Conversation

idubrov
Copy link
Owner

@idubrov idubrov commented May 6, 2024

Re-implementing the diffing algorithm to fix an issue when "kind" of the node changes (array into an object or vice-versa), #37.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (7a1b4c2) to head (b9a1fad).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
+ Coverage   89.13%   91.05%   +1.92%     
==========================================
  Files           2        2              
  Lines         230      246      +16     
==========================================
+ Hits          205      224      +19     
+ Misses         25       22       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Re-implementing the diffing algorithm to fix an issue when "kind" of
the node changes (array into an object or vice-versa), #37.

Fix some invalid tests, add more tests.
@idubrov idubrov merged commit 0217b48 into main May 6, 2024
4 checks passed
@idubrov idubrov deleted the new-diff-impl branch May 6, 2024 02:45
@idubrov idubrov mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant