Skip to content

Conversation

staudtMarius
Copy link
Member

Resolves #303

Note MS: We need to wait for the next release of the API, before we can merge this.

This comment has been minimized.

This comment has been minimized.

@staudtMarius staudtMarius marked this pull request as ready for review December 2, 2024 14:40
danielfeismann
danielfeismann previously approved these changes Dec 2, 2024
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for updating this

Copy link
Member

@sebastian-peter sebastian-peter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just made tiny changes, looks all good

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 40.00% Coverage (56.60% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:mobilitySimulator

View in SonarQube

@sebastian-peter sebastian-peter merged commit 6eba515 into main Dec 2, 2024
2 checks passed
@sebastian-peter sebastian-peter deleted the ms/#303-adapt-to-recent-changes-in-api branch December 2, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to the recent changes in simonaAPI.
3 participants