Use snapshot dependencies #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Codecov Report
@@ Coverage Diff @@
## dev #126 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 25 25
Lines 1512 1512
Branches 236 236
=====================================
Misses 1512 1512 Continue to review full report at Codecov.
|
This comment has been minimized.
This comment has been minimized.
johanneshiry
previously approved these changes
Jan 11, 2022
This comment has been minimized.
This comment has been minimized.
ckittl
commented
Jan 17, 2022
Comment on lines
+1
to
+6
| # Workaround for splotless with java 17 | ||
| org.gradle.jvmargs=--add-exports jdk.compiler/com.sun.tools.javac.api=ALL-UNNAMED \ | ||
| --add-exports jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED \ | ||
| --add-exports jdk.compiler/com.sun.tools.javac.parser=ALL-UNNAMED \ | ||
| --add-exports jdk.compiler/com.sun.tools.javac.tree=ALL-UNNAMED \ | ||
| --add-exports jdk.compiler/com.sun.tools.javac.util=ALL-UNNAMED |
There was a problem hiding this comment.
This is only a workaround and shall be fixed with #130
to comply with latest API
This comment has been minimized.
This comment has been minimized.
1 similar comment
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: edu.ie3:OSMoGrid |
|
Also removes the deprecated Java implementation. It can be found in this archive branch. |
t-ober
approved these changes
Jan 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #125
Is currently block by failing CI pipeline (and thus missing snapshot deployment) in PowerSystemUtils (ie3-institute/PowerSystemUtils#205 and ie3-institute/PowerSystemUtils#207)