unit symbols to DIN 1301-1 for PowerSystemUnits

[danielfeismann]

resolves #278

[codecov]

Codecov Report

Merging #279 (960a603) into main (e1913b5) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##               main     #279   +/-   ##
=========================================
  Coverage     66.14%   66.14%           
  Complexity      231      231           
=========================================
  Files            40       40           
  Lines          1208     1208           
  Branches        117      117           
=========================================
  Hits            799      799           
  Misses          376      376           
  Partials         33       33           

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1913b5...960a603. Read the comment docs.

[sebastian-peter]

Looks all good to me, thanks for this PR!

I noticed that not all units are registered with addUnit, thus parsing these quantities from Strings does not work. BUT, this shall be solved in a separate PR: #280 :)

[sebastian-peter]

Maybe I was a bit quick with my approval. I just noticed there are different definitions of "per unit": PU and p.u.
Does a standardized naming exist here as well? If not, we should at least provide some unified definition here.

[danielfeismann]

Maybe I was a bit quick with my approval. I just noticed there are different definitions of "per unit": PU and p.u. Does a standardized naming exist here as well? If not, we should at least provide some unified definition here.

I did not find anything on this. Personally I would prefer p.u. and also this follows the rule of lowercase when it's not dedicated to a person (and isn't a liter :))

[sebastian-peter]

Thanks!

[sebastian-peter]

I just noticed that an addition to the changelog is still missing :) Would be great if you could supply that

[sonarqubegithubprchecks]

Analysis Details

0 Issues

• 0 Bugs
• 0 Vulnerabilities
• 0 Code Smells

Coverage and Duplications

• 100.00% Coverage (64.70% Estimated after merge)
• 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

[sebastian-peter]

Thanks a lot!