Skip to content

Added VolumetricFlowRate #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 11, 2023
Merged

Added VolumetricFlowRate #364

merged 5 commits into from
May 11, 2023

Conversation

jo-bao
Copy link
Contributor

@jo-bao jo-bao commented May 11, 2023

Resolves #363

@jo-bao jo-bao requested a review from danielfeismann May 11, 2023 07:44
@jo-bao jo-bao self-assigned this May 11, 2023
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@codecov
Copy link

codecov bot commented May 11, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: +0.07 🎉

Comparison is base (dacb8e8) 67.31% compared to head (fc43fa9) 67.38%.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main     #364      +/-   ##
============================================
+ Coverage     67.31%   67.38%   +0.07%     
  Complexity      234      234              
============================================
  Files            42       42              
  Lines          1288     1291       +3     
  Branches        118      118              
============================================
+ Hits            867      870       +3     
  Misses          387      387              
  Partials         34       34

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks

This comment has been minimized.

Sign in to view
@sonarqubegithubprchecks
Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (65.80% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: edu.ie3:utils

View in SonarQube

danielfeismann
danielfeismann approved these changes May 11, 2023
View reviewed changes
Copy link
Member

@danielfeismann danielfeismann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@danielfeismann danielfeismann merged commit 492270d into main May 11, 2023
@danielfeismann danielfeismann deleted the jb/#363-volumetricflowrate branch May 11, 2023 08:57
@jo-bao jo-bao mentioned this pull request May 15, 2023
Closed
@sebastian-peter sebastian-peter added this to the Version 2.1 milestone Feb 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@danielfeismann danielfeismann danielfeismann approved these changes

Assignees

@jo-bao jo-bao

Labels

None yet

Projects

None yet

Milestone

Version 2.1

Development

Successfully merging this pull request may close these issues.

Adding quantity of volumetric flow rate

3 participants

@jo-bao @danielfeismann @sebastian-peter