Fixed the fix of version Check #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhilippSchmelter
added
bug
This comment has been minimized.
This comment has been minimized.
sebastian-peter
approved these changes
Apr 29, 2025
|
Analysis Details0 Issues
Coverage and Duplications
Project ID: edu.ie3:utils |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #559
This pull request includes updates to improve version checking logic and documentation. The most important changes include refining the version check script to handle additional branch types and updating the changelog to reflect these improvements.
Improvements to version checking logic:
scripts/version_check.sh: Updated the conditional logic in thesemver_gtfunction to ensure thatdependabotbranches are treated consistently withfeaturebranches when their versions match the main branch. Removed redundant checks fordependabotbranches.Documentation updates:
CHANGELOG.md: Added an entry to document the improved version check logic under the "Fixed" section.