- 
                Notifications
    
You must be signed in to change notification settings  - Fork 0
 
Initial setup of pp2psdm converter #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
# Conflicts: # poetry.lock # pp2psdm/conversion/pandapower.py # pp2psdm/grid.py # pp2psdm/io/utils.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found some parts that could be improved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks fine. I just have two minor remarks.
# Conflicts: # poetry.lock
| 
           The tests currently failing are caused by pandapower v3, once this is fixed this PR should be fine in my opinion.  | 
    
resolves #11