Skip to content

Conversation

@danielfeismann
Copy link
Member

resolves #11

@danielfeismann danielfeismann self-assigned this Sep 11, 2024
@danielfeismann danielfeismann added the enhancement New feature or request label Sep 11, 2024
@danielfeismann danielfeismann marked this pull request as ready for review September 12, 2024 13:33
# Conflicts:
#	poetry.lock
#	pp2psdm/conversion/pandapower.py
#	pp2psdm/grid.py
#	pp2psdm/io/utils.py
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found some parts that could be improved.

@jo-bao jo-bao requested a review from staudtMarius March 3, 2025 07:08
Copy link
Member

@staudtMarius staudtMarius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine. I just have two minor remarks.

@danielfeismann
Copy link
Member Author

The tests currently failing are caused by pandapower v3, once this is fixed this PR should be fine in my opinion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Initial setup of pp2psdm converter

4 participants