Skip to content

Only communicate the next tick of activation of EV simulation as a whole #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2024
Merged

Only communicate the next tick of activation of EV simulation as a whole #184

merged 2 commits into from
Jun 20, 2024

Conversation

sebastian-peter
Copy link
Member

Resolves #176

@sebastian-peter sebastian-peter added the enhancement New feature or request label Jun 18, 2024
@sebastian-peter sebastian-peter added this to the 0.5.0 milestone Jun 18, 2024
@sebastian-peter sebastian-peter self-assigned this Jun 18, 2024
@sebastian-peter sebastian-peter requested a review from jo-bao June 18, 2024 11:04
jo-bao
jo-bao approved these changes Jun 19, 2024
View reviewed changes
Copy link
Contributor

@jo-bao jo-bao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So for me it's fine beside two small remarks (but maybe it's personal preference)

@sebastian-peter sebastian-peter merged commit 99e1f15 into dev Jun 20, 2024
@sebastian-peter sebastian-peter deleted the sp/#176-single-next-tick branch June 20, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jo-bao jo-bao jo-bao approved these changes

Assignees

@sebastian-peter sebastian-peter

Labels
enhancement New feature or request
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.

Only communicate the next tick of activation of EV simulation as a whole
2 participants
@sebastian-peter @jo-bao