Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

F proxy ytdlp #350

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

F proxy ytdlp #350

wants to merge 6 commits into from

Conversation

mfarre
Copy link

@mfarre mfarre commented Jul 18, 2024

  • [ x] I have read CONTRIBUTE.md

With this PR it is possible to configure yt_dlp with a proxy and with a flag check the proxy certificate or ignore it.

In the YAML configuration:
reading:
yt_args:
proxy: "<proxy_address>"
proxy-check-certificate: False

@rom1504
Copy link
Collaborator

rom1504 commented Jul 27, 2024

Hey, I think these points would help

  • Making the ci pass
  • Adding a test using a proxy (either an open one publicly available or starting a local one in the CI for testing purposes)
  • Adding a note in the readme about proxy support
  • Adding recommendation on what proxy / proxy software to use and speeds observed if using a proxy

The first point is necessary. The rest would be nice

@mfarre
Copy link
Author

mfarre commented Jul 29, 2024

thanks @rom1504, I think I addressed some changes that should make the CI go, added some comments in the readme and more general details in the yt-dlp specific examples section.

ultranity added a commit to ultranity/video2dataset that referenced this pull request Dec 22, 2024
make it possible to easily support options like proxy & cookies as defined in https://github.com/yt-dlp/yt-dlp/blob/master/yt_dlp/YoutubeDL.py when downloading, helpful to fix issue like iejMac#347 iejMac#348

this works like iejMac#350 but more general.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants