Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Made changes for applying ranking loss directly to the TaskNN #48

Merged
merged 14 commits into from
Sep 26, 2021
Merged

Made changes for applying ranking loss directly to the TaskNN #48

merged 14 commits into from
Sep 26, 2021

Conversation

leejayyoon
Copy link
Collaborator

Made changes for applying ranking loss directly to the TaskNN.

Just check few lines in

  • structured_prediction_baselines/modules/loss/multilabel_classification/nce_mlc_loss.py
  • structured_prediction_baselines/modules/loss/nce_loss.py

others are all configs.

dhruvdcoder
dhruvdcoder reviewed Aug 28, 2021
View reviewed changes
Copy link
Collaborator

@dhruvdcoder dhruvdcoder left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just have one question that I asked below

structured_prediction_baselines/modules/loss/nce_loss.py Show resolved Hide resolved
@dhruvdcoder dhruvdcoder added configs Updates to configs--models and/or sweep. enhancement New feature or request labels Aug 29, 2021
@leejayyoon
Copy link
Collaborator Author

@dhruvdcoder I wans't sure why minor changes in the following files are throwing
Tests / -python-3.8-os-macos-latest. Any ideas?

  • structured_prediction_baselines/modules/loss/multilabel_classification/nce_mlc_loss.py
  • structured_prediction_baselines/modules/loss/nce_loss.py

dhruvdcoder and others added 9 commits September 6, 2021 20:50
@leejayyoon leejayyoon merged commit 58e6596 into main Sep 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhruvdcoder dhruvdcoder dhruvdcoder approved these changes

Assignees
No one assigned
Labels
configs Updates to configs--models and/or sweep. enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leejayyoon @dhruvdcoder