-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
let stateless-nonce use SHA-2 #17
Conversation
Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
draft-birkholz-rats-epoch-markers.md
Outdated
: HMAC w/ SHA-1 computed over the CBOR serialisation of TimeToken encoded as a | ||
20-bytes string. | ||
: HMAC w/ SHA-224 computed over the CBOR serialisation of TimeToken encoded as | ||
a 28-bytes string. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now if we could spend four more bytes to get a hash that is actually widely supported in hardware and software (SHA-256)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess we could. The whole idea behind SHA-1 was being able to do everything in 32 bytes, which fits well in "a certain RoT"'s API.
draft-birkholz-rats-epoch-markers.md
Outdated
|
||
A stateless-nonce supports the above use case by encoding a Posix time (i.e., | ||
the epoch identifier), alongside a minimal set of metadata, authenticated with | ||
a symmetric key in a self-contained and compact (starting at 40 bytes) token. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "starting at" is not Bourne out by the CDDL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure I get your point: with a 0-length Pad (the inf), it serialises to 40 bytes. That's what I wanted to say here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't see how to go beyond the 40-byte token, but I probably focused on the non-agile hash too much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, got it, sorry, not enough coffee :-)
* use SHA-256 * remove wrong size lower bound Signed-off-by: Thomas Fossati <thomas.fossati@arm.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This now looks good.
Adding optional agility might be a next step, but this one can go in.
No description provided.