Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add recording-name api key endpoint; appauth url fix #8081

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

jennifer-richards
Copy link
Member

@jennifer-richards jennifer-richards commented Oct 24, 2024

The main fix here is to register the /api/meeting/session/recording-name endpoint as valid for PersonalApiKey endpoints.

Along the way, found that tests were not validating the PersonalApiKey instances they were generating, so this updates the PersonalApiKeyFactory to do that validation and replaces calls to PersonalApiKey.objects.create() with the factory.

This conversion revealed a minor bug in the URL pattern for /api/appauth/ which is also fixed.

Copy link

codecov bot commented Oct 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.89%. Comparing base (c7f6bde) to head (52bd41a).
Report is 130 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8081      +/-   ##
==========================================
+ Coverage   88.78%   88.89%   +0.10%     
==========================================
  Files         296      304       +8     
  Lines       41320    41351      +31     
==========================================
+ Hits        36687    36760      +73     
+ Misses       4633     4591      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jennifer-richards jennifer-richards changed the title fix: add endpoint option for recording-name fix: add recording-name api key endpoint; appauth url fix Oct 25, 2024
@rjsparks rjsparks merged commit 3130ecd into ietf-tools:main Oct 25, 2024
9 checks passed
@jennifer-richards jennifer-richards deleted the new-endpoint branch October 25, 2024 13:54
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants