Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: keep the ftp dir in sync when the datatracker creates artifacts #8401

Merged
merged 7 commits into from
Jan 9, 2025

Conversation

rjsparks
Copy link
Member

@rjsparks rjsparks commented Jan 7, 2025

No description provided.

Copy link

codecov bot commented Jan 7, 2025

Codecov Report

Attention: Patch coverage is 86.04651% with 6 lines in your changes missing coverage. Please review.

Project coverage is 88.80%. Comparing base (4f53cad) to head (59fbcac).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
ietf/doc/views_material.py 81.81% 2 Missing ⚠️
ietf/doc/views_status_change.py 84.61% 2 Missing ⚠️
ietf/submit/utils.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8401      +/-   ##
==========================================
- Coverage   88.81%   88.80%   -0.02%     
==========================================
  Files         312      312              
  Lines       40876    40888      +12     
==========================================
+ Hits        36304    36309       +5     
- Misses       4572     4579       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@jennifer-richards jennifer-richards left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like it does the advertised things to me.

One question about whether the underlying behavior in the yang checker is good practice, but that's more of an aside.

@rjsparks rjsparks merged commit 7d464fc into ietf-tools:main Jan 9, 2025
9 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 13, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants