Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Capitalize "SVG" in "Artwork only available as svg" #1169

Closed
1 task done
ajeanmahoney opened this issue Sep 26, 2024 · 2 comments · Fixed by #1170
Closed
1 task done

Capitalize "SVG" in "Artwork only available as svg" #1169

ajeanmahoney opened this issue Sep 26, 2024 · 2 comments · Fixed by #1170
Labels
enhancement New feature or request text Issues in text output

Comments

@ajeanmahoney
Copy link
Collaborator

Description

Thanks for #1140! Please capitalize "SVG" in the output.

Current:
(Artwork only available as svg: see https://www...

Requested:
(Artwork only available as SVG: see https://www...

Code of Conduct
@ajeanmahoney ajeanmahoney added the enhancement New feature or request label Sep 26, 2024
@kesara
Copy link
Member

kesara commented Sep 26, 2024

If the artwork type is unknown, the string will be Artwork only available as (unknown type): https://.

@kesara
Copy link
Member

kesara commented Sep 26, 2024

In xml2rfc artwork type is a free string 1.
The proposed change will capitalize any string in that type attribute.

Footnotes

  1. https://ietf-tools.github.io/xml2rfc/#section-2.6.7 ↩

kesara added a commit to kesara/xml2rfc that referenced this issue Sep 26, 2024
@kesara
fix(text): Capitalize "type" in non-ASCII artwork message
d88289c 
Fixes ietf-tools#1169
@kesara kesara added the text Issues in text output label Sep 26, 2024
@kesara kesara mentioned this issue Sep 26, 2024
Merged
kesara added a commit that referenced this issue Sep 30, 2024
@kesara
fix(text): Capitalize "type" in non-ASCII artwork message (#1170)
83e897f 
* chore: Run yestests pre-changes

* fix(text): Capitalize "type" in non-ASCII artwork message

Fixes #1169

* chore: Run yestests post-changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request text Issues in text output
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(text): Capitalize "type" in non-ASCII artwork message kesara/xml2rfc
2 participants
@kesara @ajeanmahoney