fix: build PDF with Weasyprint 53 #725
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(originally at https://trac.ietf.org/trac/xml2rfc/ticket/696) (also at https://bugs.debian.org/1001824) Weasyprint 53 and later no longer use cairo and pango, so xml2rfc tests for PDF generation capability need updating. Also, it appears that test_text_ content is obsolete with the new Weasyprint. The test fails even though PDF generation succeeds. On debian and debian-derived systems, the suggestions that remain in run.py when weasyprint isn't available are rather over-complicated, but debian can continue to patch in more streamlined suggestions for its distribution.
NGPixel
changed the title
|
Closing this PR in favour of #802. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch is from @kitterma, i'm just forwarding it from https://trac.ietf.org/trac/xml2rfc/ticket/696 (it's also at https://bugs.debian.org/1001824)
Weasyprint 53 and later no longer use cairo and pango, so xml2rfc tests for PDF generation capability need updating. Also, it appears that test_text_ content is obsolete with the new Weasyprint. The test fails even though PDF generation succeeds.
On debian and debian-derived systems, the suggestions that remain in run.py when weasyprint isn't available are rather over-complicated,but debian can continue to patch in more streamlined suggestions for its distribution.