-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Use bib.ietf.org for citations #804
Conversation
Tests are failing because reference.DOI.10.1145/2975159 doesn't have |
Is the DTD still relevant?
Sent from mobile, sorry for terse
… On 6. Jul 2022, at 03:46, Kesara Rathnayake ***@***.***> wrote:
Tests are failing because reference.DOI.10.1145/2975159 doesn't have date element under front element.
This violates rfc2629.dtd.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
|
The DTD does not reflect the actual schema being used? From https://authors.ietf.org/rfcxml-vocabulary it says the “date” attribute is optional:
If xml2rfc wants to make it mandatory, the spec needs to be updated. CC: @strogonoff |
@ronaldtse: The reference file doesn't just have to be valid according to the grammar, it also has to be a usable reference. https://bib.ietf.org/public/rfc/bibxml-doi/reference.DOI.10.1145/2975159.xml fails that in a way that is almost comical. |
This is true for xml2rfc v3. |
@cabo I'm perplexed about this comment:
Are you commenting about the format of the anchor reference being different from the old one? Am I missing a joke here?
@kesara thanks for the clarification. From what I understand, the BibXML service produces BibXML that targets xml2rfc v3 compliance. |
If the goal is to have full compatibility with v2 XML schema, and that the data be given in v2 XML, I suggest that these tools do not be migrated to use We can separately create a duplicate static site for @rjsparks any thoughts here? |
I think the objective was somewhat fuzzy in that we are trying to comply with xml2rfc v3, but we also try to be compatible with the old data. Missing According to https://github.com/ietf-ribose/bibxml-service/issues/228#issuecomment-1198141887, it seems like we can omit The only alternative is to supply fake date information… |
@ronaldtse I suppose @cabo hints at DOI anchor being different. This is something that was raised before and had been fixed (the fix hadn’t made it to production yet, but can be seen in action on staging instance). |
That is absolutely not acceptable. The RFP was quite clear that this service would continue to make bibxml available at the existing URLs. This conversation is now hitting alarming levels, and it may be that we cannot use this new service as implemented at all. The characterization that this is there only for v2 is incorrect. The legacy v2 paths and things that rely on v2v3 will be heavy users, but those things, like kramdown rfc, which has a huge amount of active use will continue to need to be able to reference new documents. You are trying to shed a requirement that cannot be shed. Because of illnesses and travel it may be week after next before we can be on a call, but a call is essential at this point. We will work to set it up by direct email. |
Note: I gave up trying to make the tests run -- too many dependencies before I ran out of time to waste on this. But at least xml2rfc itself seems to work. Note: I gave up trying to update pycountry to 22.3.5 as listed in the xml2rfc requirements.txt, because the pycountry 22.3.5 tests failed; instead I patched xml2rfc to accept the version in pkgsrc for now. Since xml2rfc had been rendered completely nonfunctional by updates to its dependencies, I believe this is a better state than it was in even if the tests can't be run. Changes: - [`dbdda51`](ietf-tools/xml2rfc@dbdda51) - Lighter styling on internal iref links *(PR [#963](ietf-tools/xml2rfc#963) by [@martinthomson](https://github.com/martinthomson))* - [`ff1c061`](ietf-tools/xml2rfc@ff1c061) - Add support for Noto Math font *(PR [#971](ietf-tools/xml2rfc#971) by [@kesara](https://github.com/kesara))* - [`636dd08`](ietf-tools/xml2rfc@636dd08) - update CHANGELOG.md + py file versions for v3.16.0 [skip ci] *(commit by [@kesara](https://github.com/kesara))* - [`7cae8ad`](ietf-tools/xml2rfc@7cae8ad) - Remove mt.css and mt.js *(PR [#976](ietf-tools/xml2rfc#976) by [@martinthomson](https://github.com/martinthomson))* - [`ad2e035`](ietf-tools/xml2rfc@ad2e035) - Permit non-ASCII within <t> without the use of <u> *(PR [#895](ietf-tools/xml2rfc#895) by [@cabo](https://github.com/cabo))* - [`6b9aede`](ietf-tools/xml2rfc@6b9aede) - Add editorial stream *(PR [#958](ietf-tools/xml2rfc#958) by [@kesara](https://github.com/kesara))* -↘️ *addresses issue [#896](undefined) opened by [@alicerusso](https://github.com/alicerusso)* - [`5b687b1`](ietf-tools/xml2rfc@5b687b1) - Add 'auto' class for (most) parenthesized xref links *(PR [#948](ietf-tools/xml2rfc#948) by [@martinthomson](https://github.com/martinthomson))* - [`388d4b9`](ietf-tools/xml2rfc@388d4b9) - Update to pypdf>=3.2.1 on base docker file *(PR [#954](ietf-tools/xml2rfc#954) by [@kesara](https://github.com/kesara))* - [`6c9be77`](ietf-tools/xml2rfc@6c9be77) - Expand a problematic reference *(PR [#959](ietf-tools/xml2rfc#959) by [@kesara](https://github.com/kesara))* - [`b811bfd`](ietf-tools/xml2rfc@b811bfd) - update CHANGELOG.md + py file versions for v3.15.3 [skip ci] *(commit by [@kesara](https://github.com/kesara))* - [`5bbf3f7`](ietf-tools/xml2rfc@5bbf3f7) - **deps**: Move from PyPDF2 to pypdf>=3.2.1 *(PR [#953](ietf-tools/xml2rfc#953) by [@kesara](https://github.com/kesara))* - [`1381bb8`](ietf-tools/xml2rfc@1381bb8) - Move sourcecode classes *(PR [#839](ietf-tools/xml2rfc#839) by [@martinthomson](https://github.com/martinthomson))* - [`592ab81`](ietf-tools/xml2rfc@592ab81) - Only overwrite font-family when producing PDFs *(PR [#937](ietf-tools/xml2rfc#937) by [@martinthomson](https://github.com/martinthomson))* - [`a3adb84`](ietf-tools/xml2rfc@a3adb84) - Fix margin issue with dl after p inside a li *(PR [#941](ietf-tools/xml2rfc#941) by [@kesara](https://github.com/kesara))* - [`9308e40`](ietf-tools/xml2rfc@9308e40) - Update walkpdf to fix PyPDF deprecation warnings *(PR [#934](ietf-tools/xml2rfc#934) by [@kesara](https://github.com/kesara))* - [`0d3958c`](ietf-tools/xml2rfc@0d3958c) - Include OpenPGP certificates for signing the project in each release *(PR [#931](ietf-tools/xml2rfc#931) by [@dkg](https://github.com/dkg))* - [`b451ded`](ietf-tools/xml2rfc@b451ded) - Add support for Python 3.11 *(PR [#942](ietf-tools/xml2rfc#942) by [@kesara](https://github.com/kesara))* - [`9ff2476`](ietf-tools/xml2rfc@9ff2476) - Include all changes in Changelog *(PR [#944](ietf-tools/xml2rfc#944) by [@kesara](https://github.com/kesara))* - [`d86b1f2`](ietf-tools/xml2rfc@d86b1f2) - update CHANGELOG.md + py file versions for v3.15.2 [skip ci] *(commit by [@kesara](https://github.com/kesara))* - [`af9d83e`](ietf-tools/xml2rfc@af9d83e) - Skip Weasyprint 57.0 in tests *(PR [#932](ietf-tools/xml2rfc#932) by [@kesara](https://github.com/kesara))* - [`908365f`](ietf-tools/xml2rfc@908365f) - Use wcwidth to determine the monospace textual length of a string *(PR [#914](ietf-tools/xml2rfc#914) by [@Flowdalic](https://github.com/Flowdalic))* - [`0b42319`](ietf-tools/xml2rfc@0b42319) - Drop dependency on kitchen *(PR [#913](ietf-tools/xml2rfc#913) by [@Flowdalic](https://github.com/Flowdalic))* - [`1a910d9`](ietf-tools/xml2rfc@1a910d9) - Expand table columns in text output *(PR [#919](ietf-tools/xml2rfc#919) by [@kesara](https://github.com/kesara))* - [`4f9e700`](ietf-tools/xml2rfc@4f9e700) - Add Noto Sans Symbols 2 font to PDF template *(PR [#926](ietf-tools/xml2rfc#926) by [@kesara](https://github.com/kesara))* - [`18b34d8`](ietf-tools/xml2rfc@18b34d8) - Fix PDF tests *(PR [#920](ietf-tools/xml2rfc#920) by [@kesara](https://github.com/kesara))* - [`7337517`](ietf-tools/xml2rfc@7337517) - Correct spelling mistakes *(PR [#917](ietf-tools/xml2rfc#917) by [@jsoref](https://github.com/jsoref))* - [`08605de`](ietf-tools/xml2rfc@08605de) - Improve PDF generation debug logs *(PR [#907](ietf-tools/xml2rfc#907) by [@kesara](https://github.com/kesara))* - [`12a960e`](ietf-tools/xml2rfc@12a960e) - Use specified font families on SVG *(PR [#910](ietf-tools/xml2rfc#910) by [@kesara](https://github.com/kesara))* - [`70de803`](ietf-tools/xml2rfc@70de803) - Use noto fonts for non-latin unicode monospaced characters *(PR [#909](ietf-tools/xml2rfc#909) by [@kesara](https://github.com/kesara))* - [`dd2b0fe`](ietf-tools/xml2rfc@dd2b0fe) - Add bottom margin to .artwork > pre *(PR [#912](ietf-tools/xml2rfc#912) by [@kesara](https://github.com/kesara))* - [`58706b8`](ietf-tools/xml2rfc@58706b8) - Remove redundant code labels from CSS *(PR [#916](ietf-tools/xml2rfc#916) by [@kesara](https://github.com/kesara))* - [`055d64d`](ietf-tools/xml2rfc@055d64d) - Add xml2rfc class to HTML body element *(PR [#847](ietf-tools/xml2rfc#847) by [@martinthomson](https://github.com/martinthomson))* - [`7fec225`](ietf-tools/xml2rfc@7fec225) - Add classes to xref *(PR [#867](ietf-tools/xml2rfc#867) by [@martinthomson](https://github.com/martinthomson))* - [`cc6b083`](ietf-tools/xml2rfc@cc6b083) - Fix table colspan issue in text format *(PR [#886](ietf-tools/xml2rfc#886) by [@kesara](https://github.com/kesara))* - [`2475447`](ietf-tools/xml2rfc@2475447) - Include the published date when ipr is none *(PR [#897](ietf-tools/xml2rfc#897) by [@kesara](https://github.com/kesara))* - [`20cdb44`](ietf-tools/xml2rfc@20cdb44) - Fix odd page break inside rows in PDF output *(PR [#879](ietf-tools/xml2rfc#879) by [@kesara](https://github.com/kesara))* - [`2c9dfaf`](ietf-tools/xml2rfc@2c9dfaf) - Return orgnization for orgnization only contacts *(PR [#837](ietf-tools/xml2rfc#837) by [@kesara](https://github.com/kesara))* - [`9821dc6`](ietf-tools/xml2rfc@9821dc6) - RTL unicode issue in PDF *(PR [#884](ietf-tools/xml2rfc#884) by [@kesara](https://github.com/kesara))* - [`c67f5fd`](ietf-tools/xml2rfc@c67f5fd) - Align center aligned ASCII art correctly *(PR [#838](ietf-tools/xml2rfc#838) by [@kesara](https://github.com/kesara))* - [`701d5ce`](ietf-tools/xml2rfc@701d5ce) - Add github issue templates *(commit by [@kesara](https://github.com/kesara))* - [`c6343a9`](ietf-tools/xml2rfc@c6343a9) - Update WeasyPrint *(PR [#802](ietf-tools/xml2rfc#802) by [@kesara](https://github.com/kesara))* - [`95dba00`](ietf-tools/xml2rfc@95dba00) - Fix typo in README file *(PR [#843](ietf-tools/xml2rfc#843) by [@bkmgit](https://github.com/bkmgit))* - [`0f06e27`](ietf-tools/xml2rfc@0f06e27) - Prevent submission date warnings for RFCs *(PR [#842](ietf-tools/xml2rfc#842) by [@kesara](https://github.com/kesara))* - [`e5c45d4`](ietf-tools/xml2rfc@e5c45d4) - Add an option to disable rfc-local.css link *(PR [#840](ietf-tools/xml2rfc#840) by [@martinthomson](https://github.com/martinthomson))* - [`41b177a`](ietf-tools/xml2rfc@41b177a) - Fix tests to adapt bib.ietf.org *(PR [#852](ietf-tools/xml2rfc#852) by [@kesara](https://github.com/kesara))* - [`c9b9d09`](ietf-tools/xml2rfc@c9b9d09) - Update valid tests for --no-rfc-local option *(PR [#854](ietf-tools/xml2rfc#854) by [@kesara](https://github.com/kesara))* - [`63de72a`](ietf-tools/xml2rfc@63de72a) - Use bib.ietf.org for citations *(PR [#804](ietf-tools/xml2rfc#804) by [@kesara](https://github.com/kesara))* - [`ad44bb8`](ietf-tools/xml2rfc@ad44bb8) - Render unicode characters in SVG elements correctly *(PR [#832](ietf-tools/xml2rfc#832) by [@kesara](https://github.com/kesara))* - [`6938d80`](ietf-tools/xml2rfc@6938d80) - Drop support for Python 3.6 *(PR [#796](ietf-tools/xml2rfc#796) by [@kesara](https://github.com/kesara))* - [`47270ba`](ietf-tools/xml2rfc@47270ba) - Handle date type errors gracefully *(PR [#795](ietf-tools/xml2rfc#795) by [@cabo](https://github.com/cabo))* - [`79fd4d9`](ietf-tools/xml2rfc@79fd4d9) - Stop crashing when author element doesn't have a name *(PR [#800](ietf-tools/xml2rfc#800) by [@cabo](https://github.com/cabo))* - [`d5f8a1c`](ietf-tools/xml2rfc@d5f8a1c) - Use bib.ietf.org for citations *(PR [#799](ietf-tools/xml2rfc#799) by [@kesara](https://github.com/kesara))* - [`b94d6bb`](ietf-tools/xml2rfc@b94d6bb) - **deps**: Update Python dependencies *(PR [#797](ietf-tools/xml2rfc#797) by [@kesara](https://github.com/kesara))* - [`f73ece7`](ietf-tools/xml2rfc@f73ece7) - Update setuptools metadata *(PR [#789](ietf-tools/xml2rfc#789) by [@kesara](https://github.com/kesara))* - [`1643d68`](ietf-tools/xml2rfc@1643d68) - Display long ASCII art correctly in PDF *(PR [#788](ietf-tools/xml2rfc#788) by [@kesara](https://github.com/kesara))* - [`51e8b24`](ietf-tools/xml2rfc@51e8b24) - Add support for Python 3.10 *(PR [#772](ietf-tools/xml2rfc#772) by [@dkg](https://github.com/dkg))* - [`46399d7`](ietf-tools/xml2rfc@46399d7) - Implement emboldening primary iref entries *(PR [#778](ietf-tools/xml2rfc#778) by [@cabo](https://github.com/cabo))* - [`e0095fd`](ietf-tools/xml2rfc@e0095fd) - Remove Python version specific test results *(PR [#780](ietf-tools/xml2rfc#780) by [@kesara](https://github.com/kesara))* - [`42568b3`](ietf-tools/xml2rfc@42568b3) - evaluate date.today() on class init, not import *(PR [#774](ietf-tools/xml2rfc#774) by [@jennifer-richards](https://github.com/jennifer-richards))* - [`07ef95e`](ietf-tools/xml2rfc@07ef95e) - Fix warnings in text and manpage *(PR [#775](ietf-tools/xml2rfc#775) by [@kesara](https://github.com/kesara))* - [`6b32a5d`](ietf-tools/xml2rfc@6b32a5d) - Render text without toc *(PR [#766](ietf-tools/xml2rfc#766) by [@cabo](https://github.com/cabo))* - [`384399c`](ietf-tools/xml2rfc@384399c) - Display ASCII names for authors in references *(PR [#771](ietf-tools/xml2rfc#771) by [@kesara](https://github.com/kesara))* - [`8436c2f`](ietf-tools/xml2rfc@8436c2f) - Make index sort case insensitive *(PR [#763](ietf-tools/xml2rfc#763) by [@kesara](https://github.com/kesara))* - [`0884e8d`](ietf-tools/xml2rfc@0884e8d) - Don't attempt to select initials when fullname contains non Latin characters *(PR [#760](ietf-tools/xml2rfc#760) by [@kesara](https://github.com/kesara))* - [`9e12093`](ietf-tools/xml2rfc@9e12093) - Make long sourcecode sections breakable *(PR [#764](ietf-tools/xml2rfc#764) by [@kesara](https://github.com/kesara))* - [`24406e5`](ietf-tools/xml2rfc@24406e5) - Bug fix in tests/input/draft-miek-test.v3.xml *(PR [#738](ietf-tools/xml2rfc#738) by [@kesara](https://github.com/kesara))* - [`72255eb`](ietf-tools/xml2rfc@72255eb) - Pin PyPDF2 to 2.16.* versions *(PR [#762](ietf-tools/xml2rfc#762) by [@kesara](https://github.com/kesara))* - [`8fc7efb`](ietf-tools/xml2rfc@8fc7efb) - Update deprecated tox configuration option *(PR [#746](ietf-tools/xml2rfc#746) by [@kesara](https://github.com/kesara))*
#799 was incomplete, this change fixes the issue.
Fixes #792