Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Optimize docker images #855

Merged
merged 3 commits into from
Aug 11, 2022

Conversation

kesara
Copy link
Member

@kesara kesara commented Aug 10, 2022

As per comments in #849 (comment), attempt to optimize the docker images generated by xml2rfc.

@kesara kesara requested a review from NGPixel August 10, 2022 04:58
@kesara
Copy link
Member Author

kesara commented Aug 10, 2022

@martinthomson I can't add you as a reviewer because of the project restrictions to stop spam, but appreciate your comments on this PR.

docker/base.Dockerfile Outdated Show resolved Hide resolved
docker/dev.Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few tips, but this should be a lot faster and leaner as-is.

docker/base.Dockerfile Outdated Show resolved Hide resolved
docker/base.Dockerfile Outdated Show resolved Hide resolved
Copy link
Contributor

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now for the fun comments...

It really depends on how far down the rabbit hole you want to get.

docker/base.Dockerfile Outdated Show resolved Hide resolved
docker/base.Dockerfile Outdated Show resolved Hide resolved
@kesara kesara requested a review from NGPixel August 11, 2022 00:58
@kesara kesara merged commit f75e932 into ietf-tools:main Aug 11, 2022
@kesara kesara deleted the build/improve-docker-images branch August 11, 2022 04:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants