Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add A_AAC codec ID #917

Merged
merged 4 commits into from
Dec 22, 2024
Merged

add A_AAC codec ID #917

merged 4 commits into from
Dec 22, 2024

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Nov 24, 2024

The "stripped ADTS header" seems to correspond more or less to the raw_data_block() in the spec.

@robUx4 robUx4 added codec mapping spec_codecs Codec Matroska spec document target labels Nov 24, 2024
Copy link
Contributor

@JeromeMartinez JeromeMartinez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would use SHOULD instead of MUST for the legacy CodecIDs as it is expected to be supported by decoders, legacy encoders may use that and I prefer to avoid considering such stream as invalid but not blocking.

@robUx4 robUx4 force-pushed the a-aac branch 2 times, most recently from f2d52b7 to d7109e8 Compare November 24, 2024 14:33
@robUx4 robUx4 force-pushed the a-aac branch 2 times, most recently from a08195a to 2a850d7 Compare November 24, 2024 16:27
@robUx4
Copy link
Contributor Author

robUx4 commented Dec 22, 2024

I double checked that A_AAC is matching the raw_data_block() in FFmpeg (done through aac_adtstoasc).

@robUx4 robUx4 merged commit f3cb14b into ietf-wg-cellar:master Dec 22, 2024
2 checks passed
@robUx4 robUx4 deleted the a-aac branch December 22, 2024 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
codec mapping spec_codecs Codec Matroska spec document target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants