-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Can the window parameter be 0? #141
Comments
iirc the rationale was that This could be reconsidered, though I remember we (long time ago) used non-negative intentionally :) |
The Retry-After fields appears more similar to the |
@Acconut I think there are two ways to interpret w=0. It either means that the quota is replenished after zero time, and therefore there is effectively no quota. Or it means there is no reset window and so w=0 is equivalent to not providing a w parameter at all. This can be used for the "trial" scenario. I suspect rather than have this ambiguity, we should just make the value a positive integer greater than zero. |
I agree. That makes more sense for such a document. |
According to https://www.ietf.org/archive/id/draft-ietf-httpapi-ratelimit-headers-08.html#name-window-parameter, the window parameter is a non-negative integer, meaning that it can also be 0. Does it make sense to have a window size of 0 seconds? Should this be allowed or should we require it to be greater than 0?
The text was updated successfully, but these errors were encountered: