Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Streamlined Scope #10

Merged
merged 11 commits into from
Oct 5, 2021
Merged

[WIP] Streamlined Scope #10

merged 11 commits into from
Oct 5, 2021

Conversation

quartzjer
Copy link
Collaborator

There are two significant things to note in this PR:

  1. Renaming of the derive step and "derivation" to the prove step and generating proofs, to be more consistent with the usage of "proofs" elsewhere in the draft.
  2. Removing all language regarding the mapping of what values are in which payload slot, leaving this to the application or a companion spec.

The result is a simpler spec that focuses strictly on the cryptographic container with pluggable proof algorithms.

@quartzjer quartzjer mentioned this pull request Sep 20, 2021
Closed
OR13
OR13 reviewed Sep 25, 2021
View reviewed changes
Copy link
Contributor

@OR13 OR13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is awesome, I left some comments, none of my comments are blocking as this is DIF not W3C or IETF.

@quartzjer
Copy link
Collaborator Author

Thank you @OR13, this is some excellent feedback!

I've got some work to do incorporating it, which might take me a week or so since I'll be out most of this coming week.

@OR13 OR13 mentioned this pull request Sep 28, 2021
Open
selfissued
selfissued approved these changes Oct 1, 2021
View reviewed changes
Copy link
Collaborator

@selfissued selfissued left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that this PR moves us forward, and so should be merged. That said, I'm fine with another commit being added to address some of the comments made in the PR beforehand.

This was referenced Oct 5, 2021
Closed
Closed
@quartzjer
Copy link
Collaborator Author

@OR13 I think I've either made some improvements or filed/linked issues for all the feedback and points you raised, if I missed any I'm happy to keep refining too.

OR13
OR13 reviewed Oct 5, 2021
View reviewed changes
draft-jmiller-json-web-proof.md

All of these follow the same pattern of taking multiple claims (a.k.a., "attributes" or "messages" in the literature) and binding them together into an issued credential. These are then later securely one-way transformed into a presentation, revealing potentially only a subset of the original claims as required.
All of these follow the same pattern of taking multiple claims (a.k.a., "attributes" or "messages" in the literature) and binding them together into an issued credential. These are then later securely one-way transformed into a presentation that reveals potentially only a subset of the original claims, predicate proofs of the claim values, or only proofs of knowledge of the claims.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

like this change.

@quartzjer
Copy link
Collaborator Author

Thanks all for the feedback!

@quartzjer quartzjer merged commit 9e9b7f8 into main Oct 5, 2021
@quartzjer quartzjer deleted the streamlined_scope branch October 5, 2021 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@selfissued selfissued selfissued approved these changes

@OR13 OR13 OR13 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@quartzjer @selfissued @OR13