Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(method.arity + args.size == 0) ??? #56

Closed
tagliala opened this issue Feb 27, 2024 · 0 comments · Fixed by #57
Closed

(method.arity + args.size == 0) ??? #56

tagliala opened this issue Feb 27, 2024 · 0 comments · Fixed by #57

Comments

@tagliala
Copy link
Member

tagliala commented Feb 27, 2024 •
edited
Loading

Because of operator precedence, this is the same as (method.arity + args.size) == 0, but it is confusing

hawk/lib/hawk/model/proxy.rb

Line 101 in 3d284bd

elsif method.arity < 0 && (method.arity + args.size == 0) && args.last.is_a?(Hash)

@tagliala tagliala changed the title method.arity + args.size == 0 ??? (method.arity + args.size == 0) ??? Feb 27, 2024
tagliala added a commit that referenced this issue Feb 27, 2024
@tagliala
Improve code readability
b6565f4 
Close #56
@tagliala tagliala mentioned this issue Feb 27, 2024
Merged
tagliala added a commit that referenced this issue Feb 27, 2024
@tagliala
Improve code readability
a482847 
Refine method argument check for clarity: Both
`(method.arity + args.size == 0)` and `(method.arity + args.size) == 0`
are equivalent due to operator precedence, but the latter is preferred
for improved readability.

Close #56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve code readability ifad/hawk
1 participant
@tagliala