Ifeelgoods generate api route #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ability to specify the formatter thought the configuration and influence the other +api+ paramters (such as desc) form the formatter.
Adding a recursion for getting routes form mounted engines. Also checking if we need to add the api_base_url to the path instead of removing the api_base_url when loading the path from routes: doesn't play well with inheritance of api_base_url.
| route_set.routes.each do |route| | ||
| if route.app.respond_to?(:routes) && route.app.routes.is_a?(ActionDispatch::Routing::RouteSet) | ||
| # recursively go though the moutned engines | ||
| flatten_routes.concat(rails_routes(route.app.routes)) |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added some more customization possibilities via configuration.
I've also changed removing the '()' from the path, as this probably depends on the usage and people might have different preferences that can be customized by the custom formatter: therefore I find it better to keep the info there in the base and removing it later, as the other way around, we loose the information at the beginning and we can't do anything about that in the custom formatter.
I've also change the way it handles the api_base_url, as the previous version was not working when customizing the api_base_url from resource description. After this change, it just doesn't try to modify the apis that come from the routes.
I've also removed the initial filtering base on the api_base_url (for similar reasons) and enhanced support for engines.