-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Publish combined message. #3
Comments
Hi @bprevost -- My initial impression is it's redundant to publish data on multiple topics, but I do understand the reason behind this suggestion. It feels like this is a job for DDS QoS but I'd have to research the possibilities to lockstep pub/subs -- have you done any research on that topic? |
Our research indicates that just because the TOF publishes the multiple topics near-simultaneously, we do not have a guarantee on the receiving end (due to queuing, etc) which amplitude message goes with which xyz message, etc. Also, it's easier to process a single topic callback from the TOF, rather than handle amplitude, xyz, confidence, etc. and have to match them together. |
The way this is typically done in ROS1 is to use message_filters and in your case, you specifically want the Time Synchronizer I have not used these in ROS2 yet, but it looks like they have been ported and also available as binaries since crystal:
Alternatively, and specific to HTH. |
Thanks @tpanzarella! @bprevost does this solve your needs? If so I'll mark this 'wontfix' and close. |
Yes, thank-you. We'll look at message_filters or investigate/make an alternative in ROS2. |
I propose that a 'combined' message is published, containing the amplitude image, xyz_image, temperature, and uptime, etc. so that a client node needs only 1 callback to access the camera, and so that there is a guarantee as to which images are paired with each other. We already have the code available for this and it is available upon request.
The text was updated successfully, but these errors were encountered: