-
Notifications
You must be signed in to change notification settings - Fork 70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
3rdParty Directory? #29
Comments
Yes it is, this is where the xmlrpc library needs to be checked out to. The XMLRPC find script in CMake is broken on windows. It relies on a script to locate the xmlrpc on the system. Due to the fact it is written in bash there is no way to get this running on a regular Windows installation. You can see my PR on the CMake project related to this issue. In my opinion the way to solve this is to use the CMake approach and create an package configuration file this is how for example GLog or Qt5+ handle things. But be warned using the package config approach breaks building of object libraries. See my comment on the GLog project for more details. So my idea is to add this package configuration file for my xmlrpc fork. Fixing the XMLRPCFind.cmake is another approach but this will take some time to be available to the broad audience. Any ideas? |
This cleans up the Windows build script and fixes Windows build warnings. This closes ifm#29 by removing the 3rdParty directory. Signed-off-by: Christian Ege <christian.ege@ifm.com>
This cleans up the Windows build script and fixes Windows build warnings. This closes ifm#29 by removing the 3rdParty directory. Signed-off-by: Christian Ege <christian.ege@ifm.com>
This cleans up the Windows build script and fixes Windows build warnings. This closes ifm#29 by removing the 3rdParty directory. Signed-off-by: Christian Ege <christian.ege@ifm.com>
This cleans up the Windows build script and fixes Windows build warnings. This closes #29 by removing the 3rdParty directory. Signed-off-by: Christian Ege <christian.ege@ifm.com>
This cleans up the Windows build script and fixes Windows build warnings. This closes #29 by removing the 3rdParty directory. Signed-off-by: Christian Ege <christian.ege@ifm.com>
@graugans Do you have insights on this 3rdParty top-level directory? Is it needed any more? I think it was introduced as part of the Windows builds. However, I have not (yet) done a Windows build so I am unsure of its purpose. Let me know.
The text was updated successfully, but these errors were encountered: