UX: Navigation bar fixed #2176
Closed
UX: Navigation bar fixed #2176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julianguyen
requested changes
Oct 16, 2022
| @@ -5,7 +5,7 @@ | |||
| box-sizing: border-box; | |||
| padding: $size-40 34px; | |||
| scroll-behavior: smooth; | |||
| margin: 0 auto; | |||
| margin: 50px auto; | |||
There was a problem hiding this comment.
We'll want to apply similar logic in /app/assets/stylesheets/dashboard/dashboard_content.scss.
Or else this is happening on the signed in pages:
| top: 0; | ||
| left: 0; | ||
| right: 0; | ||
| z-index: 1000; |
There was a problem hiding this comment.
It would be a better design to have this background only show up once the user starts scrolling in the page. We can do that by applying the transparent black background through React JS in /client/app/components/Header/index.jsx
|
Any updates here? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This is my follow up PR from #2171 as I mistakenly force-pushed my commit.
With the following changes in
client/app/components/Header/Header.scssandapp/assets/stylesheets/static/static_content.scss, the navbar will be sticky.I have added margin-top to the main content of the page as requested in #2171 (comment)
More Details
As. @julianguyen pointed out in #2171 the background color
$black-80The result will look like this. However, I haven't made this change yet and wanted to ask if this is the desired result. :) If so, please let me know and I will make the necessary changes.Corresponding Issue
#2155
Reviewing this pull request? Check out our Code Review Practices guide if you haven't already!